Is Rolling over Always Profitable for the Trader?

No, rolling over is not always profitable. The profitability depends entirely on the market condition, specifically whether the market is in contango or backwardation.

In contango, rolling a long position results in a loss (negative roll yield). Only in backwardation, where the expiring contract is more expensive, does rolling a long position result in a profit (positive roll yield).